Dfr 2689 auto date pension sharing annex #1944
Conversation
This reverts commit 40dbf6d.
Plan Result (aat) |
Plan Result (prod) |
| String authToken, | ||
| LocalDate approvalDate, | ||
| String caseId) throws Exception { | ||
| log.info("Adding date stamp to Pension Sharing Annex : {}", document); |
There was a problem hiding this comment.
Consider if CaseDocument isn't log safe. For instance, if document_filename contains anything that could identify an individual. You could refer to case Id too as you've passed in.
There was a problem hiding this comment.
If you decide on something log safe, consider including it on your DocumentStorageException below. Consider including the passed in case id too.
| throw new StampDocumentException("Pension Order document PDF is flattened / not editable."); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
looks like textBox.getDefaultAppearance() returns a string. So you could try isBlank rather than the null and empty check.
There was a problem hiding this comment.
I'd pass case id in, so I could include in the exception. Just slightly easier for support :-D
| @@ -141,7 +141,7 @@ void given_case_when_NotPaperApplication_then_shouldNotTriggerConsentOrderApprov | |||
| } | |||
|
|
|||
| @Test | |||
| void givenCase_whenNoPendsion_thenShouldUpdateStateToConsentOrderMadeAndBulkPrint() { | |||
| void givenCase_whenNoPension_thenShouldUpdateStateToConsentOrderMadeAndBulkPrint() { | |||
| CallbackRequest callbackRequest = | |||
| doValidCaseDataSetUp(NO_PENSION_VALID_JSON); | |||
| whenServiceGeneratesDocument().thenReturn(caseDocument()); | |||
There was a problem hiding this comment.
New function getApprovalDate has been added to this handler. That can either take caseData with a LocalDate or String and responds with a null or OK string. Given that, suggest a test.
...a/uk/gov/hmcts/reform/finrem/caseorchestration/service/PensionAnnexDateStampServiceTest.java
Show resolved
Hide resolved
...a/uk/gov/hmcts/reform/finrem/caseorchestration/service/PensionAnnexDateStampServiceTest.java
Show resolved
Hide resolved
| PDField field = acroForm.get().getField(FORM_P1_DATE_OF_ORDER_TEXTBOX_NAME); | ||
| PDTextField textBox = (PDTextField) field; | ||
| if (textBox.getDefaultAppearance() == null && textBox.getDefaultAppearance().isEmpty()) { | ||
| textBox.setDefaultAppearance(DEFAULT_PDTYPE_PREFIX + DEFAULT_PDTYPE_FONT_HELV + DEFAULT_PDTYPE_POSTFIX); |
There was a problem hiding this comment.
Just use a single constant for the default appearance (it can be private too)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Jira link
https://tools.hmcts.net/jira/browse/DFR-2689
Change description
Auto date document - pension sharing annex