jakarta libs upgrade #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build.gradle
Outdated
| // resolutionStrategy.eachDependency { details -> | ||
| // if (details.requested.group == 'io.netty') { | ||
| // details.useVersion "4.1.77.Final" | ||
| // } |
There was a problem hiding this comment.
please delete commented code
build.gradle
Outdated
| implementation (group: 'com.fasterxml.jackson.core', name: 'jackson-core', version: versions.jackson) { | ||
| force = true | ||
| } | ||
| implementation (group: 'com.fasterxml.jackson.core', name: 'jackson-databind', version: '2.15.2') |
There was a problem hiding this comment.
can't we use 2.13.2 ( version: versions.jackson))
There was a problem hiding this comment.
local dependency check scan flags jackson-databind 2.13.2 as vulnerable to CVE-2020-36518, CVE-2022-42003, CVE-2022-42004
build.gradle
Outdated
| implementation 'net.logstash.logback:logstash-logback-encoder:6.4' | ||
|
|
||
| implementation group: 'com.microsoft.azure', name: 'azure-storage-blob', version: '11.0.0' | ||
| implementation group: 'com.azure', name: 'azure-storage-blob', version: '12.18.0' |
There was a problem hiding this comment.
latest is 12.23.0, better to use latest version, if it is compatable
kiran-yenigala-hmcts
approved these changes
Aug 3, 2023
# Conflicts: # build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DTSRD-72
Change description
Does this PR introduce a breaking change? (check one with "x")