Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXUI-433-pass all fields to evaluate show condition #1521

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

RiteshHMCTS
Copy link
Collaborator

@RiteshHMCTS RiteshHMCTS commented Jul 18, 2023

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EXUI-433
https://tools.hmcts.net/jira/browse/EXUI-702

Change description

pass all fields to evaluate show condition

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@RiteshHMCTS RiteshHMCTS requested a review from codaimaster July 19, 2023 16:22
codaimaster
codaimaster previously approved these changes Jul 24, 2023
Copy link
Contributor

@codaimaster codaimaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but not yet confident enough to suggest it can go with a CI/CD.

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants