Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUI-8608 QM follow up on the query tab #1513

Merged

Conversation

johnbenjamin-hmcts
Copy link
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/EUI-8608

Change description

Query Management - Follow-up UI on the query tab

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs import changes

Daniel-Lam
Daniel-Lam previously approved these changes Jul 7, 2023
Copy link
Contributor

@Daniel-Lam Daniel-Lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbenjamin-hmcts - all looks good here; approved

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codaimaster codaimaster dismissed stale reviews from connorpgpmcelroy and Daniel-Lam August 16, 2023 09:48

The merge-base changed after approval.

Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested

Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Daniel-Lam
Daniel-Lam previously approved these changes Nov 27, 2023
Copy link
Contributor

@Daniel-Lam Daniel-Lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbenjamin-hmcts - all looks good here; approved

Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Daniel-Lam Daniel-Lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnbenjamin-hmcts - re-approved after base branch change

Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@johnbenjamin-hmcts johnbenjamin-hmcts merged commit 6029336 into Release Nov 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants