LAU-1008 unit and integration test #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinYSpasov
requested changes
Dec 5, 2024
| @@ -209,4 +213,93 @@ void testShouldLogErrorWhenDeleteLinkedCasesFails() { | |||
| verify(failedToDeleteCaseFamilyHolder, times(2)).addCaseFamily(defaultCaseFamily); | |||
| verifyNoMoreInteractions(caseLinkRepository); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
You are not verifying if the following lines are not executed.
caseEventRepository.deleteByCaseDataId(caseData.getId()); caseDataRepository.delete(caseDataEntity.get());
There was a problem hiding this comment.
This has been added to all unit test
| @@ -520,6 +520,45 @@ protected static Stream<Arguments> provideCaseDeletionScenarios() { | |||
| 1504259907351231L, 1504259907351230L, | |||
| 1504259907351229L)), | |||
| Map.of("FT_MasterCaseType", List.of(1504259907351234L,1504259907351228L)) | |||
| ), | |||
There was a problem hiding this comment.
Please add LAU scenario too.
There was a problem hiding this comment.
Once log and audit exception is thrown , it will throw the exception to higher level and deletion will stop there. It's difficult to add Log and audit exception Integration test
MartinYSpasov
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/LAU-1008
Change description
Remote Deletion Exception
Does this PR introduce a breaking change? (check one with "x")