Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: render stories/grid in iframe only, related to #339 #711

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Akryum
Copy link
Member

@Akryum Akryum commented Apr 15, 2024

Related to #339

In preparation to not load user styles in the histoire app, this refactors to only use iframes to render stories/variants.

  • Remove single layout iframe property
  • Render variants grid inside an iframe

Copy link

codesandbox bot commented Apr 15, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

stackblitz bot commented Apr 15, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for histoire-examples-svelte3 ready!

Name Link
🔨 Latest commit efb719b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-svelte3/deploys/661d407e875dc5000839bf1d
😎 Deploy Preview https://deploy-preview-711--histoire-examples-svelte3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for histoire-controls ready!

Name Link
🔨 Latest commit efb719b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-controls/deploys/661d407edc3f8b0007f66de4
😎 Deploy Preview https://deploy-preview-711--histoire-controls.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for histoire-examples-vue3 ready!

Name Link
🔨 Latest commit efb719b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-examples-vue3/deploys/661d407ee23aba0008c62df0
😎 Deploy Preview https://deploy-preview-711--histoire-examples-vue3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for histoire-site ready!

Name Link
🔨 Latest commit efb719b
🔍 Latest deploy log https://app.netlify.com/sites/histoire-site/deploys/661d407e4d556600079757d6
😎 Deploy Preview https://deploy-preview-711--histoire-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@rubencanovaca rubencanovaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it fix this #544?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants