Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix apollo client infinite reload bug in player #2791

Merged
merged 6 commits into from
Jul 20, 2022

Conversation

Vadman97
Copy link
Member

@Vadman97 Vadman97 commented Jul 20, 2022

Apollo upgrade for security issue fix causes infinite-reload bug in some onCompleted callback invocation.
Wrapping with useCallback to memoize the argument fixes the issue.

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2791.d25bj3loqvp3nx.amplifyapp.com

@Vadman97 Vadman97 marked this pull request as ready for review July 20, 2022 01:14
@Vadman97 Vadman97 changed the title use absolute sourcemap urls fix apollo client infinite reload bug in player Jul 20, 2022
@Vadman97 Vadman97 merged commit ade2886 into master Jul 20, 2022
@Vadman97 Vadman97 deleted the vadim/fix-replayer-reload branch July 20, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant