fix(android): remove jcenter repository completely #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
reviewed
Dec 28, 2021
ifero
approved these changes
Jan 4, 2022
|
Done! @mikehardy |
…` works the app name in manifest was different then the configured app name, so the app did not run from the command line, now it does
you cannot just bump the version without actually doing all the changes required when you update react-native (e.g., integrating diffs from upgrade-helper) the partial change broke the example app on ios, reverting it makes the example app work again, at least up through use of Xcode-12.4. react-native 0.60 does not work with Xcode 12.5+ but that's a known issue and is solved by doing a full update of the example app, which is out of scope for a jcenter change
|
I pulled the branch and checked it locally, and the example app did not work for android or ios, so it appeared that it had not actually been tested at all @matteodanelli ? I added three commits which patched up the PR while keeping it minimal, such that the example actually works, for ios and android, and now - with the 3 extra commits verified locally via |
mikehardy
approved these changes
Jan 4, 2022
mikehardy
changed the title
|
Hi @mikehardy, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed jcenter from the android source and from the android example.
Replaced jcenter with maven jitpack.
Updated flipper and react-native versions to match the latest v0.65.