Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBX-2390: Create a JBoss Tools adaptation layer in Hibernate Tools #4226

Merged
merged 1 commit into from
Jun 23, 2023
Merged

HBX-2390: Create a JBoss Tools adaptation layer in Hibernate Tools #4226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions jbt/src/main/java/org/hibernate/tool/orm/jbt/wrp/ConfigurationWrapperFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ static interface ConfigurationWrapper extends Wrapper {
Iterator<PersistentClass> getClassMappings();
void setPreferBasicCompositeIds(boolean b);
void setReverseEngineeringStrategy(RevengStrategy reverseEngineeringStrategy);
void readFromJDBC();
}

static class ConfigurationWrapperInvocationHandler implements InvocationHandler {
Expand Down
38 changes: 38 additions & 0 deletions jbt/src/test/java/org/hibernate/tool/orm/jbt/wrp/ConfigurationWrapperFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,44 @@ public void testSetReverseEngineeringStrategy() {
}
}

@Test
public void testReadFromJDBC() throws Exception {
// For native configuration
try {
nativeConfigurationWrapper.readFromJDBC();
fail();
} catch (RuntimeException e) {
assertEquals(
e.getMessage(),
"Method 'readFromJDBC' should not be called on instances of " + NativeConfigurationWrapperImpl.class.getName());
}
// For reveng configuration
Connection connection = DriverManager.getConnection("jdbc:h2:mem:test");
Statement statement = connection.createStatement();
statement.execute("CREATE TABLE FOO(id int primary key, bar varchar(255))");
wrappedRevengConfiguration.setProperty("hibernate.connection.url", "jdbc:h2:mem:test");
wrappedRevengConfiguration.setProperty("hibernate.default_schema", "PUBLIC");
Metadata metadata = ((RevengConfiguration)wrappedRevengConfiguration).getMetadata();
assertNull(metadata);
revengConfigurationWrapper.readFromJDBC();
metadata = ((RevengConfiguration)wrappedRevengConfiguration).getMetadata();
Iterator<PersistentClass> iterator = metadata.getEntityBindings().iterator();
PersistentClass persistentClass = iterator.next();
assertEquals("Foo", persistentClass.getClassName());
statement.execute("DROP TABLE FOO");
statement.close();
connection.close();
// For jpa configuration
try {
jpaConfigurationWrapper.readFromJDBC();
fail();
} catch (RuntimeException e) {
assertEquals(
e.getMessage(),
"Method 'readFromJDBC' should not be called on instances of " + JpaConfigurationWrapperImpl.class.getName());
}
}

private void createPersistenceXml() throws Exception {
File metaInf = new File(tempRoot, "META-INF");
metaInf.mkdirs();
Expand Down