Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBX-2390: Create a JBoss Tools adaptation layer in Hibernate Tools #4225

Merged
merged 1 commit into from
Jun 23, 2023
+35 −0
Merged

HBX-2390: Create a JBoss Tools adaptation layer in Hibernate Tools #4225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions jbt/src/main/java/org/hibernate/tool/orm/jbt/wrp/ConfigurationWrapperFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import org.hibernate.cfg.Configuration;
import org.hibernate.cfg.NamingStrategy;
import org.hibernate.mapping.PersistentClass;
import org.hibernate.tool.api.reveng.RevengStrategy;
import org.hibernate.tool.orm.jbt.util.JpaConfiguration;
import org.hibernate.tool.orm.jbt.util.NativeConfiguration;
import org.hibernate.tool.orm.jbt.util.RevengConfiguration;
Expand Down Expand Up @@ -62,6 +63,7 @@ static interface ConfigurationWrapper extends Wrapper {
SessionFactory buildSessionFactory();
Iterator<PersistentClass> getClassMappings();
void setPreferBasicCompositeIds(boolean b);
void setReverseEngineeringStrategy(RevengStrategy reverseEngineeringStrategy);
}

static class ConfigurationWrapperInvocationHandler implements InvocationHandler {
Expand Down
33 changes: 33 additions & 0 deletions jbt/src/test/java/org/hibernate/tool/orm/jbt/wrp/ConfigurationWrapperFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
import org.hibernate.cfg.DefaultNamingStrategy;
import org.hibernate.cfg.NamingStrategy;
import org.hibernate.mapping.PersistentClass;
import org.hibernate.tool.api.reveng.RevengStrategy;
import org.hibernate.tool.internal.reveng.strategy.DefaultStrategy;
import org.hibernate.tool.orm.jbt.util.JpaConfiguration;
import org.hibernate.tool.orm.jbt.util.MetadataHelper;
import org.hibernate.tool.orm.jbt.util.MockConnectionProvider;
Expand Down Expand Up @@ -633,6 +635,37 @@ public void testSetPreferBasicCompositeIds() {
}
}

@Test
public void testSetReverseEngineeringStrategy() {
RevengStrategy reverseEngineeringStrategy = new DefaultStrategy();
// For native configuration
try {
nativeConfigurationWrapper.setReverseEngineeringStrategy(reverseEngineeringStrategy);
fail();
} catch (RuntimeException e) {
assertEquals(
e.getMessage(),
"Method 'setReverseEngineeringStrategy' should not be called on instances of " + NativeConfigurationWrapperImpl.class.getName());
}
// For reveng configuration
assertNotSame(
reverseEngineeringStrategy,
((RevengConfiguration)wrappedRevengConfiguration).getReverseEngineeringStrategy());
revengConfigurationWrapper.setReverseEngineeringStrategy(reverseEngineeringStrategy);
assertSame(
reverseEngineeringStrategy,
((RevengConfiguration)wrappedRevengConfiguration).getReverseEngineeringStrategy());
// For jpa configuration
try {
jpaConfigurationWrapper.setReverseEngineeringStrategy(reverseEngineeringStrategy);
fail();
} catch (RuntimeException e) {
assertEquals(
e.getMessage(),
"Method 'setReverseEngineeringStrategy' should not be called on instances of " + JpaConfigurationWrapperImpl.class.getName());
}
}

private void createPersistenceXml() throws Exception {
File metaInf = new File(tempRoot, "META-INF");
metaInf.mkdirs();
Expand Down