Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBX-1797 Several improvements: descriptions of classes are taken from comments of database tables and ... #1268

Open
wants to merge 3 commits into
base: 5.2
Choose a base branch
from

Conversation

Bryantsev
Copy link
Contributor

  1. Added param "annotateFields" to config of hibernatetool plugin. If value of param is set to true then annotates will be generated above class fields instead of field getters.
  2. Added param "javaDocFromDbComments" to config of hibernatetool plugin. If value of param is set to true then comments of tables and their fields will be added as class and their fields javadoc description. Meta-attributes of class and fields (class-description and field-description) has priority if set
  3. Oracle metadata queries were optimized (tested at Oracle 9.2)
  4. Oracle metadata of columns includes all forms of TIMESTAMP datatype now

Improvements are divided into 3 commit

…lue of param is set to true then annotates will be generated above class fields instead of field getters. Added param "javaDocFromDbComments" to config of hibernatetool plugin. If value of param is set to true then comments of tables and their fields will be added as class and their fields javadoc description. Meta-attributes of class and fields (class-description and field-description) has priority if set.
@koentsje
Copy link
Member

Hi @Bryantsev, I will take a look at this contribution shortly. In the meantime, would it be possible to create an issue in our JIRA (https://hibernate.atlassian.net/projects/HBX) for this?

@Bryantsev Bryantsev changed the title Several improvements: descriptions of classes are taken from comments of database tables and ... HBX-1797 Several improvements: descriptions of classes are taken from comments of database tables and ... Feb 11, 2019
@Bryantsev
Copy link
Contributor Author

@molexx
Copy link

molexx commented Feb 26, 2020

Will this be merged please?

I wish to propose a further enhancement around comments which will conflict/depend on this.

@@ -241,7 +277,7 @@ public OracleMetaDataDialect() {
element.put("TABLE_SCHEM", tableResultSet.getString(2));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't there be an A in TABLE_SCHEM, I also noticed it in SQLServerDialect ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants