Skip to content

Commit

Permalink
HBX-2390: Create a JBoss Tools adaptation layer in Hibernate Tools
Browse files Browse the repository at this point in the history
  - Add new interface method 'org.hibernate.tool.orm.jbt.wrp.ConfigurationWrapperFactory.ConfigurationWrapper#setReverseEngineeringStrategy(RevengStrategy)'
  - Add new test case 'org.hibernate.tool.orm.jbt.wrp.ConfigurationWrapperFactoryTest#testSetReverseEngineeringStrategy()'

Signed-off-by: Koen Aers <[email protected]>
  • Loading branch information
koentsje committed Jun 23, 2023
1 parent 446eb2d commit 9288b17
Show file tree
Hide file tree
Showing 2 changed files with 35 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import org.hibernate.cfg.Configuration;
import org.hibernate.cfg.NamingStrategy;
import org.hibernate.mapping.PersistentClass;
import org.hibernate.tool.api.reveng.RevengStrategy;
import org.hibernate.tool.orm.jbt.util.JpaConfiguration;
import org.hibernate.tool.orm.jbt.util.NativeConfiguration;
import org.hibernate.tool.orm.jbt.util.RevengConfiguration;
Expand Down Expand Up @@ -62,6 +63,7 @@ static interface ConfigurationWrapper extends Wrapper {
SessionFactory buildSessionFactory();
Iterator<PersistentClass> getClassMappings();
void setPreferBasicCompositeIds(boolean b);
void setReverseEngineeringStrategy(RevengStrategy reverseEngineeringStrategy);
}

static class ConfigurationWrapperInvocationHandler implements InvocationHandler {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
import org.hibernate.cfg.DefaultNamingStrategy;
import org.hibernate.cfg.NamingStrategy;
import org.hibernate.mapping.PersistentClass;
import org.hibernate.tool.api.reveng.RevengStrategy;
import org.hibernate.tool.internal.reveng.strategy.DefaultStrategy;
import org.hibernate.tool.orm.jbt.util.JpaConfiguration;
import org.hibernate.tool.orm.jbt.util.MetadataHelper;
import org.hibernate.tool.orm.jbt.util.MockConnectionProvider;
Expand Down Expand Up @@ -633,6 +635,37 @@ public void testSetPreferBasicCompositeIds() {
}
}

@Test
public void testSetReverseEngineeringStrategy() {
RevengStrategy reverseEngineeringStrategy = new DefaultStrategy();
// For native configuration
try {
nativeConfigurationWrapper.setReverseEngineeringStrategy(reverseEngineeringStrategy);
fail();
} catch (RuntimeException e) {
assertEquals(
e.getMessage(),
"Method 'setReverseEngineeringStrategy' should not be called on instances of " + NativeConfigurationWrapperImpl.class.getName());
}
// For reveng configuration
assertNotSame(
reverseEngineeringStrategy,
((RevengConfiguration)wrappedRevengConfiguration).getReverseEngineeringStrategy());
revengConfigurationWrapper.setReverseEngineeringStrategy(reverseEngineeringStrategy);
assertSame(
reverseEngineeringStrategy,
((RevengConfiguration)wrappedRevengConfiguration).getReverseEngineeringStrategy());
// For jpa configuration
try {
jpaConfigurationWrapper.setReverseEngineeringStrategy(reverseEngineeringStrategy);
fail();
} catch (RuntimeException e) {
assertEquals(
e.getMessage(),
"Method 'setReverseEngineeringStrategy' should not be called on instances of " + JpaConfigurationWrapperImpl.class.getName());
}
}

private void createPersistenceXml() throws Exception {
File metaInf = new File(tempRoot, "META-INF");
metaInf.mkdirs();
Expand Down

0 comments on commit 9288b17

Please sign in to comment.