fix: cache fix for virtuoso (#4201)

[RutamBhagat]

What does this PR do?

Fixes issue #4201 by caching user profiles

Related issues

Fixes # (issue)

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Enhancement (non-breaking small changes to existing functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Explanation of the changes

/claim #4201

simplescreenrecorder-2023-12-12_23.34.08.mp4

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
web	✅ Ready (Inspect)	Visit Preview	Dec 14, 2023 10:36am

[rishi-raj-jain]

@RutamBhagat I didn't know that this can be done. A learning!

[bigint]

It is not intended to see cache requests in network too, if you see twitter they do virtual scroll nicely 🤔

[bigint]

Screen.Recording.2023-12-13.at.11.27.15.AM.mov

[bigint]

Screen.Recording.2023-12-13.at.11.30.31.AM.mov

they unmount too

[rishi-raj-jain]

Damn 🤯

[bigint]

Twitter is always a engineering marvel lol 😅

[rishi-raj-jain]

Screen.Recording.2023-12-13.at.11.30.31.AM.mov
they unmount too

Can you look into the tags they've used? are we sure they are loading images and not buffers?

[rishi-raj-jain]

Oh no they are also refetching

[rishi-raj-jain]

here goes 👇🏻

Screen.Recording.2023-12-13.at.12.41.01.PM.mov

[RutamBhagat]

It is not intended to see cache requests in network too, if you see twitter they do virtual scroll nicely 🤔

Just as Rishi mentioned Twitter cache requests are also visible in the network

simplescreenrecorder-2023-12-13_14.40.17.mp4

[bigint]

@rishi-raj-jain @RutamBhagat this happens only if you disable cache on dev tools! if you disable it will not be called again!

[bigint]

If its something related to disk cache we don't want to do any code changes, it can be easily done on network layer!

[bigint]

Will react memo fix it?

[RutamBhagat]

@rishi-raj-jain @RutamBhagat this happens only if you disable cache on dev tools! if you disable it will not be called again!

I am sorry, I am a bit confused, when I disable caching on twitter it still tries to refetch the images

simplescreenrecorder-2023-12-14_17.23.58.mp4

[RutamBhagat]

Will react memo fix it?

No it still shows that the request is cached in the networks tab but I feel like React.memo is a cleaner implementation

hey.list.mp4

[bigint]

Request is cached because we added cache headers on firewall!

[bigint]

@rishi-raj-jain @RutamBhagat this happens only if you disable cache on dev tools! if you disable it will not be called again!

I am sorry, I am a bit confused, when I disable caching on twitter it still tries to refetch the images

simplescreenrecorder-2023-12-14_17.23.58.mp4

you need to disable aka uncheck the option

[bigint]

Closing this, we can move discussion to issue!