feat: add api section #1201
Draft
feat: add api section #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
requested changes
Nov 3, 2019
source/index.pug
Outdated
| p.intro-feature-desc Various plugins are available to generate sitemap and RSS, insert player for music or video, intergrate search engine and support most template engines. |
There was a problem hiding this comment.
"Various plugins are available to further enhance your site. Easily add RSS feed, embed audio/video, search engine integration/optimization, add support for most template engines and many more."
I use "audio" instead of "music" to cover podcast and radio.
themes/navy/layout/index.swig
Outdated
| <div class="inner plugin-wrapper"> | ||
| <div class="plugin-thumbnail"> | ||
| <div class="plugin-thumbnail-container"> | ||
| <img src="/img/carbon.svg"> |
There was a problem hiding this comment.
any idea on the screenshot? or we just embed a zoomed-out screenshot of https://hexo.io/plugins/ ?
There was a problem hiding this comment.
How about free-to-use illustrations or equivalent?
e.g) followings
stevenjoezhang
force-pushed
the
add-api-section
branch
from
fd6080a
to
830daef
Compare
|
Can be merged after adding |
|
Theme name validation passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Please read and check followings before submitting a PR.
nameis unique.linkURL is correct.previewURL is correct.previewURL web site is rendered correctly.source/themes/screenshots.name.800 * 500.png.nameis unique.linkURL is correct.This is a draft of adding API section to the index. Demo can be found at Netlify and i18n will only be implement after everyone is happy with layout and text.