support wildcard domain #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Tang <[email protected]>
Signed-off-by: Thomas Tang <[email protected]>
Signed-off-by: Thomas Tang <[email protected]>
uiolee
requested changes
Sep 11, 2024
| - **exclude** - Exclude hostname. Specify subdomain when applicable, including `www`. | ||
| - 'exclude1.com' does not apply to `www.exclude1.com` nor `en.exclude1.com`. | ||
| - **exclude** - Exclude hostname. Subdomain also supported well, such as `www` or `app`. | ||
| - 'exclude1.com' now apply to `www.exclude1.com` and `en.exclude1.com` in this [commit](https://github.com/tangkunyin/hexo-filter-nofollow/commit/cf05a07054536dfaa36f986493e678252f31ad45) |
There was a problem hiding this comment.
Suggested change
| - 'exclude1.com' now apply to `www.exclude1.com` and `en.exclude1.com` in this [commit](https://github.com/tangkunyin/hexo-filter-nofollow/commit/cf05a07054536dfaa36f986493e678252f31ad45) | |
| - 'exclude1.com' apply to `www.exclude1.com` and `en.exclude1.com`. |
| @@ -12,11 +12,11 @@ function isExternal(url, config) { | |||
|
|
|||
| if (exclude && exclude.length) { | |||
| for (const i of exclude) { | |||
| if (host === i) return false; | |||
| if (i === host || (host && host.endsWith(i))) return false; | |||
| } | ||
| } | ||
|
|
||
| if (host !== sitehost) return true; | ||
| if (sitehost !== host && (host && !host.endsWith(sitehost))) return true; |
There was a problem hiding this comment.
For host to be null, it is recommended to use early return
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "hexo-filter-nofollow", | |||
| "version": "2.0.2", | |||
| "version": "2.0.3", | |||
|
#12 Some users may want a more precise match, and using wildcards by default may not be a good idea. |
Ok, got it. Then I will close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check list
Description
Support wildcard domain, that means subdomain also supported well, such as
wwworen.Now we can just configure only
exclude.comand it will be worked on*.exclude.comAdditional information
No!