Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eslint-plugin-prettier #25

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Conversation

curbengh
Copy link
Contributor

@curbengh curbengh commented Sep 12, 2019

cherry-picked #10

I haven't test compatibility with lint-staged. If it's compatible, I believe this PR has less breaking change than #22.

If this is approved, this PR must be merged before #22.

@curbengh curbengh requested a review from a team September 12, 2019 08:50
@curbengh curbengh mentioned this pull request Sep 12, 2019
@curbengh curbengh changed the title Add eslint-plugin-prettier feat: eslint-plugin-prettier Sep 13, 2019
@curbengh
Copy link
Contributor Author

curbengh commented Sep 13, 2019

Fails in hexo, prettier doesn't seem to like multi-line ternary condition.

Edit: resolved in hexojs/hexo#3717

@curbengh
Copy link
Contributor Author

curbengh commented Sep 13, 2019

Demo: hexojs/hexo#3719

@curbengh curbengh removed the request for review from a team September 13, 2019 05:42
@NoahDragon NoahDragon mentioned this pull request Sep 28, 2019
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants