Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction to deploy nicegui #834

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

kovalp
Copy link
Contributor

@kovalp kovalp commented Apr 26, 2024

This is a correction to my NiceGUI tutorial. The accepted version had a hidden deficiency in the script asgi.py. Namely, the served page is the same across different machines, browsers or browser tabs. As a matter of fact, the usual way of serving pages in NiceGUI is by using the @ui.page decorator, similarly to other web frameworks. I think it is worth to correct this unfortunate oversight on my part. The little correction will improve user experience.

@kovalp kovalp marked this pull request as ready for review April 26, 2024 17:29
@svenja11 svenja11 added the Existing tutorial Changes on an existing tutorial label Apr 29, 2024
@svenja11
Copy link
Collaborator

Thank you for the update @kovalp. The changes look good!

Please add this comment to your pull request and I will merge it:

I have read and understood the Contributor's Certificate of Origin available at the end of
https://raw.githubusercontent.com/hetzneronline/community-content/master/tutorial-template.md
and I hereby certify that I meet the contribution criteria described in it.
Signed-off-by: [submitter's name and email address here]

Remember to replace [submitter's name and email address here] with your own information.

@kovalp
Copy link
Contributor Author

kovalp commented Apr 29, 2024

I have read and understood the Contributor's Certificate of Origin available at the end of
https://raw.githubusercontent.com/hetzneronline/community-content/master/tutorial-template.md
and I hereby certify that I meet the contribution criteria described in it.
Signed-off-by: Petr Koval Kotlov [email protected]

@svenja11 svenja11 added the ready label Apr 29, 2024
@svenja11 svenja11 merged commit c42ff51 into hetzneronline:master Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Existing tutorial Changes on an existing tutorial ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants