Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform loop normalization also on litmus code #723

Closed
wants to merge 1 commit into from

Conversation

ThomasHaas
Copy link
Collaborator

No description provided.

@ThomasHaas
Copy link
Collaborator Author

This PR seems to not be needed for now.

@hernanponcedeleon
Copy link
Owner

@ThomasHaas can you also enable any other pass that is needed for #731 ?

@ThomasHaas
Copy link
Collaborator Author

There are some tests that none of our passes handle, for example:

4:    LC00:
5:       bv64 r0 := rmw[](bv64(1), &Mem0)
6:       if(bv64 r0 != bv64(1)); then goto LC01
7:       goto LC02
8:    LC01:
9:       bv64 r1 := rmw[](bv64(0), &Mem0)
10:      if(bv64 r1 != bv64(1)); then goto LC02
11:      goto LC00
12:   LC02:
13:      bv64 r2 := rmw[](bv64(0), &Mem0)
14:      if(bv64 r2 != bv64(1)); then goto LC03
15:      goto LC01

This code has overlapping loops. Here an improved BranchReordering might be able swap the last two blocks to get a proper loop.

@hernanponcedeleon
Copy link
Owner

We can keep them in the skip file for now. If we enable loop normalization, the remaining test all have the pattern from your msg above.

If no, I think we can already merge this PR.

@hernanponcedeleon
Copy link
Owner

@ThomasHaas should I merge?

@ThomasHaas
Copy link
Collaborator Author

This trivial change can also be included in #731. That one just fails because we need to exclude a bunch more tests.

@hernanponcedeleon
Copy link
Owner

Ok, I cherry-picked your commit to that branch. Closing.

@hernanponcedeleon hernanponcedeleon deleted the enable_loopTransform_litmus branch September 16, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants