Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend loop normalization #705

Merged
merged 14 commits into from
Aug 3, 2024
Merged

Extend loop normalization #705

merged 14 commits into from
Aug 3, 2024

Conversation

hernanponcedeleon
Copy link
Owner

New normalization pass to avoid problems when we have jumps from outside a loop to its middle.

@hernanponcedeleon hernanponcedeleon changed the title Jumps [DRAFT] Jumps Jul 26, 2024
@hernanponcedeleon
Copy link
Owner Author

I still need to figure out why the change of results in seqlock and ebr. If I run them directly using the C code (rather than the llvm one) and with OPTFLAGS="", I get the correct results (i.e. as in development), so there seem to be some incompatibility with this pass and the llvm ones.

@hernanponcedeleon hernanponcedeleon changed the title [DRAFT] Jumps Extend loop normalization Jul 31, 2024
@hernan-poncedeleon
Feedback implemented
5aaaa8a 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernan-poncedeleon
Feedback implemented
76b18b3 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
@hernanponcedeleon hernanponcedeleon merged commit 6582d4a into development Aug 3, 2024
1 check passed
@hernanponcedeleon hernanponcedeleon deleted the jumps branch August 3, 2024 18:21
hernanponcedeleon added a commit that referenced this pull request Aug 28, 2024
@hernanponcedeleon @hernan-poncedeleon @ThomasHaas
Extend loop normalization (#705)
396e8ec 
Signed-off-by: Hernan Ponce de Leon <[email protected]>
Co-authored-by: Hernan Ponce de Leon <[email protected]>
Co-authored-by: Thomas Haas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasHaas ThomasHaas ThomasHaas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hernanponcedeleon @ThomasHaas @hernan-poncedeleon