-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/modularization presentation #8
Merged
helloItsHEssam
merged 13 commits into
feature/modularization
from
feature/modularization-presentation
Nov 6, 2023
Merged
Feature/modularization presentation #8
helloItsHEssam
merged 13 commits into
feature/modularization
from
feature/modularization-presentation
Nov 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Access Control to Open
…ontroller - Added the DiContainer protocol for creating suitable use cases. - Added the HomeViewController for displaying the Transfer list. - Added the BaseCollectionViewController in the UI module.
- Added LargeHeaderCell for displaying titles in each section. - Added HomeCollectionViewDataSource for managing the diffable data source and cell display. - Added the HomeItem component to assist with the diffable data source.
- Added the VerticalAccount Cell for displaying vertical account information. - Added display of "All Title" and "All Account" in the view. - Added the ViewModel for fetching data from the Use Case. - Implemented a ViewModelFactory for easier creation of view models.
- Added DataTransfer for publishing new data to the UI from the ViewModel. - Add PaginationMode to handle reaching the end of a page. - Updated the Datasource based on the DataTransfer for improved data management.
…, and Local Data Fetching - Added the AccountCell component. - Implemented inheritance from AccountCell in VerticalAccountCell and FavoriteCell. - Added data fetching from local sources and display of favorite items.
- Added the DetailViewController for displaying more account information. - Added the HeaderInformationCell for presenting header content. - Added the TitleValueCell for displaying title-value pairs.
…er, ViewModel Update - Added functionality for saving and removing items from favorites. - Updated the DetailViewController to reload data as needed. - Enhanced the TransferViewModel to handle favorites addition or removal. - Added the AddRemove component for managing these operations.
…st Update - Added functionality for handling save or remove operations in the Favorites.
- Resolved the issue of displaying errors only for ViewControllers by adding an error publisher. - Improved performance by replacing the @published property with PassthroughSubject.
…d Cell Size Modification - Renamed multiple variables for improved clarity. - Updated function names and combined two functions in the ViewModel. - Set the width and height to 100 for the FavoriteAccountCell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.