apply https://github.com/helix-editor/helix/pull/5492 to latest #11081
+172
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2024 08:56
smortime
force-pushed
the
show-message-request
branch
from
34837a4
to
efb5856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies @ayoub-benali's changes from #5492 onto the latest master.
Tried and failed miserably to rebase their branch since it's 1+ year stale. Can try rebasing it again later. This unblocked me with using Metals LSP so opening this incase helps others in same situation.
All credit to Ayoub for actually implementing this and making Metals usable!
#4699