-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document completion menu bindings #10994
base: master
Are you sure you want to change the base?
Conversation
book/src/keymap.md
Outdated
| ---- | ----------- | | ||
| `Shift-Tab`, `Ctrl-p`, `Up` | Previous entry | | ||
| `Tab`, `Ctrl-n`, `Down` | Next entry | | ||
| `Escape` | Close menu and accept completion | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior is a little nuanced for escape - it's not directly handled by completion. It's actually ignored by completion and anything ignored by completion (arrow keys for example) cause the completion to be accepted. We may want to remove this from the table here and then have a blurb below that says that anything other than what's in the table causes the completion item to be accepted.
| `Shift-Tab`, `Ctrl-p`, `Up` | Previous entry | | ||
| `Tab`, `Ctrl-n`, `Down` | Next entry | | ||
| `Escape` | Close menu and accept completion | | ||
| `Ctrl-c` | Close menu and reject completion | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other one that's special cased I believe is Enter
which just accepts the completion item
Addressed feedback |
Document bindings discussed in #10976