Skip to content

Commit

Permalink
Merge pull request #96 from helios-ag/patch
Browse files Browse the repository at this point in the history
various fixes
  • Loading branch information
helios-ag committed Feb 27, 2015
2 parents 27c0d45 + adc0f64 commit b2e0d4b
Show file tree
Hide file tree
Showing 12 changed files with 363 additions and 365 deletions.
45 changes: 24 additions & 21 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
language: php

php:
- 5.3.3
- 5.3
- 5.4
- 5.5


matrix:
allow_failures:
- php: 5.5

before_script:
- composer install --dev --prefer-source

script: phpunit --coverage-text

notifications:
email:
- [email protected]
language: php

php:
- 5.4
- 5.5
- 5.6
- hhvm


matrix:
allow_failures:
- php: 5.6
- hhvm

before_script:
- travis_retry composer self-update
- travis_retry composer install --dev --prefer-source

script: phpunit --coverage-text

notifications:
email:
- [email protected]

6 changes: 3 additions & 3 deletions Command/DumpEmoticonsCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ protected function configure()
* @param $src
* @param $dst
*/
private function recurse_copy($src,$dst)
private function recurseCopy($src,$dst)
{
$dir = opendir($src);
@mkdir($dst);
Expand Down Expand Up @@ -62,11 +62,11 @@ protected function execute(InputInterface $input, OutputInterface $output)

$emoticonsFolder = $this->getContainer()->getParameter('kernel.root_dir').$input->getOption('emoticons-folder');

if (!file_exists($emoticonsFolder) and !is_dir($emoticonsFolder)) {
if (!file_exists($emoticonsFolder) && !is_dir($emoticonsFolder)) {
return $output->writeln('<error>Emoticons folder does not exist</error>');
}

$this->recurse_copy($emoticonsFolder,$webFolder);
$this->recurseCopy($emoticonsFolder,$webFolder);

$output->writeln('<comment>Emoticons dumped succesfully</comment>');
}
Expand Down
2 changes: 1 addition & 1 deletion Composer/ScriptHandler.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace FM\BbcodeBundle\Composer;

use Symfony\Component\Process\Process;
use Sensio\Bundle\DistributionBundle\Composer\ScriptHandler as BaseHandler;

/**
Expand All @@ -21,3 +20,4 @@ public static function installEmoticons($event)
}

}

1 change: 0 additions & 1 deletion Decoda/Decoda.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace FM\BbcodeBundle\Decoda;

use Decoda\Component;
use Decoda\Loader\DataLoader;
use Decoda\Loader;
use Decoda\Hook;
Expand Down
1 change: 0 additions & 1 deletion Decoda/Hook/EmoticonHook.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

use Symfony\Component\HttpKernel\CacheWarmer\CacheWarmerInterface;

use Symfony\Component\Config\Resource\FileResource;
use Symfony\Component\Config\ConfigCache;

use Decoda\Decoda;
Expand Down
3 changes: 2 additions & 1 deletion Emoticon/EmoticonCollection.php
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,5 @@ public function addResource(ResourceInterface $resource)
{
$this->resources[] = $resource;
}
}
}

2 changes: 1 addition & 1 deletion Emoticon/Loader/YamlFileLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ private function validate($content, $file)
}

if (!is_array($content)) {
throw new InvalidArgumentException(sprintf('The emoticon file "%s" is not valid.', $file));
throw new \InvalidArgumentException(sprintf('The emoticon file "%s" is not valid.', $file));
}

return $content;
Expand Down
3 changes: 2 additions & 1 deletion Emoticon/Matcher/Matcher.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,5 @@ public function getSmilies()
{
return $this->emoticons->getSmilies();
}
}
}

Loading

0 comments on commit b2e0d4b

Please sign in to comment.