Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Namada SDK dependency and adjusted denominations. #34

Closed
wants to merge 1 commit into from

Conversation

murisi
Copy link

@murisi murisi commented Jun 12, 2024

Adjusting Hermes to work with anoma/namada#3409 . The incompatibilities with the linked PR mainly arose from:

  • the redenomination of amounts used in the IBC packets to facilitate computations with MASP amounts
  • changes in the derivation of TransparentAddresses to include IBC receiver data as a way to attain replay protection

@murisi murisi force-pushed the murisi/masp-ibc-replay-protect-2 branch 2 times, most recently from 6dd0edf to 54db124 Compare June 12, 2024 19:28
@murisi murisi requested a review from yito88 June 12, 2024 19:40
@murisi murisi force-pushed the murisi/masp-ibc-replay-protect-2 branch from 54db124 to fc5649f Compare June 12, 2024 21:00
Copy link
Member

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.
I'll merge this when the Namada PR for masp ibc replay protection branch is merged.

@murisi murisi force-pushed the murisi/masp-ibc-replay-protect-2 branch from fc5649f to 621a9e8 Compare June 20, 2024 19:01
@yito88
Copy link
Member

yito88 commented Jul 11, 2024

Skipped merging because Hermes doesn't set MASP txs anymore.

@yito88 yito88 closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants