Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tendermint client for Namada #10

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix Tendermint client for Namada #10

merged 1 commit into from
Oct 17, 2023

Conversation

yito88
Copy link
Member

@yito88 yito88 commented Oct 17, 2023

When rpc_addr is https://{host}:{port}/{path}, Namada client didn't work because the specified address was wrong.
This fix sets the ledger address as rpc_addr itself in the config.
(We need to convert Url for Namada tendermint-rpc.)

@yito88 yito88 requested a review from Fraccaman October 17, 2023 18:33
@yito88 yito88 merged commit 9835e74 into 1.6.0-namada Oct 17, 2023
3 of 37 checks passed
@yito88 yito88 deleted the yuji/fix-namada-tm-client branch October 17, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fraccaman Fraccaman Fraccaman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yito88 @Fraccaman