for Namada 3428 - Improve gas interface

heliaxdev · Jul 9, 2024 · c2fce62 · c2fce62
1 parent 5550adf
commit c2fce62
Show file tree

Hide file tree

Showing 8 changed files with 65 additions and 61 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -39,10 +39,10 @@ tendermint-rpc                   = { version = "=0.36.0" }
 tendermint-testgen               = { version = "=0.36.0" }
 
 # Namada dependencies
-namada_ibc        = { git = "https://github.com/anoma/namada", rev = "59332a22943e47c74cfcec4a2d08281822ba75f9" }
-namada_parameters = { git = "https://github.com/anoma/namada", rev = "59332a22943e47c74cfcec4a2d08281822ba75f9" }
-namada_sdk        = { git = "https://github.com/anoma/namada", rev = "59332a22943e47c74cfcec4a2d08281822ba75f9" }
-namada_token      = { git = "https://github.com/anoma/namada", rev = "59332a22943e47c74cfcec4a2d08281822ba75f9" }
+namada_ibc        = { git = "https://github.com/anoma/namada", rev = "4f0b027da53c10e600e61c54a6900b4fba485726" }
+namada_parameters = { git = "https://github.com/anoma/namada", rev = "4f0b027da53c10e600e61c54a6900b4fba485726" }
+namada_sdk        = { git = "https://github.com/anoma/namada", rev = "4f0b027da53c10e600e61c54a6900b4fba485726" }
+namada_token      = { git = "https://github.com/anoma/namada", rev = "4f0b027da53c10e600e61c54a6900b4fba485726" }
 
 # Other dependencies
 abscissa_core            = "=0.6.0"

diff --git a/crates/relayer/src/chain/namada/error.rs b/crates/relayer/src/chain/namada/error.rs
@@ -23,8 +23,8 @@ define_error! {
             |_| { "borsh decoding failed" },
 
         DryRun
-            { tx_results: namada_sdk::tx::data::BatchResults<String> }
-            |e| { format!("Dry run to simulate a transaction failed: {:?}", e.tx_results) },
+            { tx_result: namada_sdk::tx::data::TxResult<String> }
+            |e| { format!("Dry run to simulate a transaction failed: {:?}", e.tx_result) },
     }
 }
 

diff --git a/crates/relayer/src/chain/namada/query.rs b/crates/relayer/src/chain/namada/query.rs
@@ -136,7 +136,7 @@ impl NamadaChain {
                         height,
                     )]);
                 }
-                let events = tx_result.batch_results.iter().filter_map(|(_, r)| {
+                let events = tx_result.iter().filter_map(|(_, r)| {
                     r.as_ref().map(|batched_tx_result| {
                         // Get IBC events when the transaction was accepted
                         if batched_tx_result.is_accepted() {

diff --git a/crates/relayer/src/chain/namada/tx.rs b/crates/relayer/src/chain/namada/tx.rs
@@ -6,11 +6,9 @@ use std::time::Instant;
 
 use ibc_proto::google::protobuf::Any;
 use itertools::Itertools;
-use namada_parameters::storage as param_storage;
 use namada_sdk::address::{Address, ImplicitAddress};
 use namada_sdk::args::TxBuilder;
 use namada_sdk::args::{Tx as TxArgs, TxCustom};
-use namada_sdk::borsh::BorshDeserialize;
 use namada_sdk::chain::ChainId;
 use namada_sdk::tx::{prepare_tx, ProcessTxResponse};
 use namada_sdk::{signing, tx, Namada};
@@ -22,7 +20,6 @@ use crate::chain::cosmos::types::gas::max_gas_from_config;
 use crate::chain::cosmos::types::tx::{TxStatus, TxSyncResult};
 use crate::chain::cosmos::wait::all_tx_results_found;
 use crate::chain::endpoint::ChainEndpoint;
-use crate::chain::requests::{IncludeProof, QueryHeight};
 use crate::error::{Error, ErrorDetail};
 
 use super::error::{Error as NamadaError, ErrorDetail as NamadaErrorDetail};
@@ -170,10 +167,6 @@ impl NamadaChain {
         let max_gas = max_gas_from_config(self.config());
         let gas_price = self.config().gas_price.price;
 
-        let gas_scale_key = param_storage::get_gas_scale_key();
-        let (value, _) = self.query(gas_scale_key, QueryHeight::Latest, IncludeProof::No)?;
-        let gas_scale = u64::try_from_slice(&value[..]).map_err(NamadaError::borsh_decode)?;
-
         let args = args.clone().dry_run_wrapper(true);
         // Set the max gas to the gas limit for the simulation
         self.prepare_tx_with_gas(&mut tx, &args, &fee_token, max_gas, gas_price)?;
@@ -201,14 +194,14 @@ impl NamadaChain {
         let estimated_gas = match response {
             ProcessTxResponse::DryRun(result) => {
                 if result
-                    .batch_results
+                    .0
                     .iter()
                     .all(|(_, r)| matches!(&r, Ok(result) if result.is_accepted()))
                 {
-                    result.gas_used.get_whole_gas_units(gas_scale)
+                    result.1.into()
                 } else {
                     // All or some of requests will fail
-                    return Err(NamadaError::dry_run(result.batch_results).into());
+                    return Err(NamadaError::dry_run(result.0).into());
                 }
             }
             _ => unreachable!("Unexpected response"),

diff --git a/e2e/namada-gaia-simple-transfers b/e2e/namada-gaia-simple-transfers
@@ -157,6 +157,7 @@ ${NAMADAC} --base-dir ${base_dir} ibc-transfer \
   --amount 50 \
   --signing-keys relayer \
   --channel-id channel-0 \
+  --gas-limit 150000 \
   --node ${NAMADA_LEDGER_ADDR}
 
 # packet-recv
@@ -207,6 +208,7 @@ ${NAMADAC} --base-dir ${base_dir} ibc-transfer \
   --amount 200 \
   --signing-keys relayer \
   --channel-id channel-0 \
+  --gas-limit 150000 \
   --node ${NAMADA_LEDGER_ADDR}
 
 # wait for relaying
@@ -324,6 +326,7 @@ ${NAMADAC} --base-dir ${base_dir} ibc-transfer \
   --amount 5 \
   --signing-keys relayer \
   --channel-id channel-0 \
+  --gas-limit 150000 \
   --node ${NAMADA_LEDGER_ADDR}
 
 # wait for relaying

diff --git a/e2e/namada-simple-transfers b/e2e/namada-simple-transfers
@@ -150,6 +150,7 @@ ${NAMADAC} --base-dir ${base_dir_a} ibc-transfer \
   --amount 100 \
   --signing-keys relayer \
   --channel-id channel-0 \
+  --gas-limit 150000 \
   --node ${LEDGER_ADDR_A}
 
 # packet-recv
@@ -198,6 +199,7 @@ ${NAMADAC} --base-dir ${base_dir_b} ibc-transfer \
   --amount 50000000 \
   --signing-keys relayer \
   --channel-id channel-0 \
+  --gas-limit 150000 \
   --node ${LEDGER_ADDR_B}
 
 # packet-recv
@@ -250,6 +252,7 @@ ${NAMADAC} --base-dir ${base_dir_a} ibc-transfer \
   --amount 200 \
   --signing-keys relayer \
   --channel-id channel-0 \
+  --gas-limit 150000 \
   --node ${LEDGER_ADDR_A}
 
 echo "~~ Transfer 300 apfel from chain B to chain A ~~"
@@ -260,6 +263,7 @@ ${NAMADAC} --base-dir ${base_dir_b} ibc-transfer \
   --amount 300 \
   --signing-keys relayer \
   --channel-id channel-0 \
+  --gas-limit 150000 \
   --node ${LEDGER_ADDR_B}
 
 wait_for_relaying ${chain_a}
@@ -329,6 +333,7 @@ ${NAMADAC} --base-dir ${base_dir_a} ibc-transfer \
   --channel-id channel-0 \
   --memo-path ${memo_path} \
   --gas-payer relayer \
+  --gas-limit 150000 \
   --node ${LEDGER_ADDR_A}
 
 wait_for_relaying ${chain_a}
@@ -419,6 +424,7 @@ ${NAMADAC} --base-dir ${base_dir_b} ibc-transfer \
   --signing-keys relayer \
   --channel-id channel-0 \
   --memo-path ${memo_path} \
+  --gas-limit 150000 \
   --node ${LEDGER_ADDR_B}
 
 wait_for_relaying ${chain_a}