-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(draft) Github action addon #368
base: master
Are you sure you want to change the base?
Conversation
* Create freebsd-maven * Rename Job freebsd-maven * Create freebsd-maven.yml * Add artifact & remove temp file * remove file without yml extension
For sure this approach has serious advantages. I think the most interesting use cases are:
Then, I must admit there are also drawbacks. The most critical one I think: this is somehow redundant with the build script used by @helge17 to build and release TuxGuitar in all flavors. Also with some information available in INSTALL.md: typically the list of build dependencies. Ideally the build script, the INSTALL.md doc and the GitHub actions should share a maximum of possible data. For example:
Also: most of TuxGuitar's code is independent from the OS, and there is an abstraction layer for ui frameworks (SWT vs. JFX). So it is clearly possible to create an incompatibility, but this should really not happen very often. @helge17: what do you think? |
My development environment is currently quite stable and a migration to Github actions would mean a lot of effort. That's why I prefer to stick with my build script. There is a certain redundancy in the script, the documentation and the Github actions, that's true. But again, I fear that the effort to fix this redundancy is currently greater than the benefit. I also think it is better to list the individual commands in the documentation instead of just saying "call script xyz". But if Github actions would help you, we can merge PR #368. I will try to keep the files up to date. Maybe I'll fall back on it at some point, for example if I can no longer manage to keep all my virtual machines running. |
Add build from GitHub Action for MacOS-13 and Ubuntu.
This is a first trial, if you find it useful, please detail which platform and OS version is of interest, I will try to do my best to add them.
Action for Mac and Ubuntu is coming from INSTALL.md
Update: add FreeBSD build for trial too
Note: add build for MacOS 12 & 13. 14 fails (as we already know)
See result here