Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased version number after updating phpsass library to fix PHP 7 bug #27

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

KZeni
Copy link
Contributor

@KZeni KZeni commented Jun 22, 2020

WP.org still has version 1.0 with PHP 7.x compatibility issues that were fixed in 2018. Just doing my part to hopefully push this key compatibility issue through to be available as the current official version available on WP.org and elsewhere (version number wasn't bumped when that change was made & it really should've been; better late than never!)

@KZeni
Copy link
Contributor Author

KZeni commented Jun 22, 2020

From #21 (comment) for some additional details/discussion:

I don't think something like PHP 7 compatibility (outright broken for most; given PHP 7's adoption) should wait any longer and/or be pushed when it comes to needing to take care of something involved like #2 before then. Ideally, this then just becomes a quick merge of that PR and then implement and tag via WP.org's SVN to address something critical like this.

There are still plenty of people out there running into this issue on the WP.org forum & elsewhere since this would be / is a great plugin to have... with or without #2 taken care of. I mean, many implement a scheme and leave it, so updating the core files after the fact might never be an issue for them while the plugin serves its full purpose, and it can be patched to take care of that later to then resolve it if/when that does come up later on in the plugin's usage (again, I don't see that holding off the plugin from not being broken with PHP 7.x in any way with it all but taken care of other than just being pushed to WP.org's SVN at this point.)

@KZeni
Copy link
Contributor Author

KZeni commented Jun 22, 2020

@markjaquith Any potential help here? I see the SVN on WP.org is also managed by you in addition to the WP.org core team.

Thanks,
Kurt

@helen helen added this to the 1.1 milestone Oct 1, 2020
@helen helen merged commit d05e2af into helen:develop Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants