FIX: url doesn't update for subsequent searches #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two-way data bindings make it hard to determine cause and effect. Now we ensure that our "watch" code is only called in response to changes of the SearchBox, whereas before it was *also* called during initial load. I also think that now that POI is being handed in, it can't be undefined within watch, so no need for that fallback. Further: was their any reason for the async dispatch?
michaelkirk
force-pushed
the
mkirk/fix-subsequent-pick-routing
branch
from
22dd834
to
06cc2fa
Compare
michaelkirk
commented
Sep 21, 2022
| methods: { | ||
| poiDisplayName, | ||
| poiSelected: function (poi?: POI) { |
There was a problem hiding this comment.
This function just seemed unused.
|
Also, now is as good a time as any to confess that I've never used vue and in fact have barely done any web development for the last 10 years, so don't hesitate to set me straight when I'm doing something crazy. |
|
Hah, I'm not much of a web developer either! This looks good to me. Certainly better than what was there before :) Will test tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES: #166
I left my individual commits in case you want to follow the commit log narrative, but feel free to squash as you see fit: