Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The place URL doesn't update with subsequent searches unless you click "clear" #166

Closed
michaelkirk opened this issue Sep 21, 2022 · 1 comment · Fixed by #168
Closed
Labels
bug Something isn't working

Comments

@michaelkirk
Copy link
Member

From: #161 (comment)

Any time I've clicked on an autocomplete result, the URL should reflect the place id of what I'm currently looking at.

Currently this works:

Search "coffee"
Click first result - see the url update with the coffee place id as expected
Click the "delete" ❌ button.
The place id is removed from the URL.
Search "sandwich"
Click first result - see the url update with the sandwich place id as expected

But this does not work:

Search "coffee"
Click first result - see the url update with the coffee place id as expected
Select the search bar text with your mouse and delete it, then search "sandwich"
Search "sandwich"
Click first result - but the url is not updated with the sandwich place id. It still has the coffee place id.

@michaelkirk
Copy link
Member Author

I'm taking a look at fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants