-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TermSet Integration #862
TermSet Integration #862
Conversation
If you run
everything passes except backwards compatibility.
even though it is there |
So if you run "pytest" alone it will return an error where it can't find the file. However, if you run "pytest test_table.py" then it'll find the file. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #862 +/- ##
==========================================
- Coverage 88.21% 86.92% -1.30%
==========================================
Files 44 45 +1
Lines 9020 9184 +164
Branches 2576 2616 +40
==========================================
+ Hits 7957 7983 +26
- Misses 752 882 +130
- Partials 311 319 +8
☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@@ -2,7 +2,7 @@ | |||
h5py==2.10 # support for selection of datasets with list of indices added in 2.10 | |||
importlib-metadata==4.2.0; python_version < "3.8" # TODO: remove when minimum python version is 3.8 | |||
importlib-resources==5.12.0; python_version < "3.9" # TODO: remove when when minimum python version is 3.9 | |||
jsonschema==2.6.0 | |||
jsonschema>=2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of this file is to be used when testing whether the minimum requirements set in pyproject.toml
are valid. Using >= instead of == defeats the point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If 2.6.0 is too small, then the minimum version should be increased both here and in pyproject.toml
linkml_runtime is not a lightweight dependency... Installing it installs
That's kind of a lot of packages, totaling at least 15 MB. Each package can introduce dependency resolution conflicts with users' environments, so in general, it is best for libraries to use as few packages as possible. Out of the many functions of linkml_runtime, we use only:
Both of those seem like it can be handled using simple YAML parsing of the LinkML YAML. |
Co-authored-by: Ryan Ly <[email protected]>
Co-authored-by: Ryan Ly <[email protected]>
Motivation
Add TermSet Integration
TODO:
How to test the behavior?
Checklist
ruff
from the source directory.