Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mamba key from GH Actions #1194

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Remove mamba key from GH Actions #1194

merged 3 commits into from
Oct 2, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Oct 1, 2024

Motivation

All conda tests are failing. It seems to be because the experimental mamba: * config is no longer supported / is broken in the setup-miniconda github action. In any case, the latest version of conda uses the libmamba solver by default so we should not need to specify mamba: * anymore.

I do not think this needs a changelog entry, but happy to add one. I added one.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (fbfabeb) to head (a32e4f1).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1194      +/-   ##
==========================================
+ Coverage   88.84%   89.02%   +0.18%     
==========================================
  Files          45       45              
  Lines        9879     9879              
  Branches     2812     2812              
==========================================
+ Hits         8777     8795      +18     
+ Misses        777      767      -10     
+ Partials      325      317       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly
Copy link
Contributor Author

rly commented Oct 1, 2024

Total runtime is about the same here vs when the workflow was last succeeding, so I think this change does not affect the conda solver speed.

@mavaylon1
Copy link
Contributor

That's nice libmamba is the default now.

@rly rly merged commit 335abdd into dev Oct 2, 2024
29 checks passed
@rly rly deleted the no_mamba_gha branch October 2, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants