Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starred DVR #394

Merged
merged 15 commits into from
Jul 27, 2024
Merged

Starred DVR #394

merged 15 commits into from
Jul 27, 2024

Conversation

qvasic
Copy link
Contributor

@qvasic qvasic commented Feb 19, 2024

Ability to add "stars" to your DVRs.

Useful feature to mark time on your DVR files: if landed a cool trick, flown your fastest lap or crashed somewhere far - just press a configured button so goggles save a "star" on your DVR, which you can later see on Playback page and in DVR player, or on filesystem of your SD card later when you edit your videos.

How to use it:

Go into Input menu, and assign "Star DVR" to an input of your choice:

hdzero-stars-1

While DVR is being recorded activate that input (e.g. click the right button) - a file is created next to the DVR file which is currently being recorded, time stamp in format "minutes:seconds" is appended to that file:

image

Go to Playback menu - files which has "star" file next to them will be marked with yellow star icon:

hdzero-stars-2

Play a DVR file with a star icon - "stars" will be shown on the timeline (up to 10 stars):

hdzero-stars-3

@MichelleRos
Copy link

Cool idea! This looks really useful.
You could change the heart/like to a star if you want it a bit more applicable for crashes etc as well :)
How did you get the heart image though?

@qvasic
Copy link
Contributor Author

qvasic commented Feb 20, 2024

Cool idea! This looks really useful. You could change the heart/like to a star if you want it a bit more applicable for crashes etc as well :)

Thanks! Yes, "star" might be more applicable to more circumstances. :)

How did you get the heart image though?

I've just written a Python script which generated required C code from picture's ASCII drawing. :)

@qvasic qvasic changed the title DVR likes Starred DVR Jul 14, 2024
@qvasic qvasic marked this pull request as ready for review July 14, 2024 14:46
@qvasic
Copy link
Contributor Author

qvasic commented Jul 14, 2024

I've finally got some time to finish this.
I've changed feature name and icon, cleaned-up the code, updated PR description.
It is ready for review @ligenxxxx .

@ligenxxxx ligenxxxx merged commit 4a05363 into hd-zero:main Jul 27, 2024
1 check passed
@ligenxxxx
Copy link
Member

@qvasic I found in actual use that when I was in video mode and started to star dvr, I couldn't tell whether the operation was successful. My suggestion is to add a new [REC] OSD that contains a ⭐ in the lower right corner. Show it when staring.

@qvasic
Copy link
Contributor Author

qvasic commented Aug 9, 2024

@qvasic I found in actual use that when I was in video mode and started to star dvr, I couldn't tell whether the operation was successful. My suggestion is to add a new [REC] OSD that contains a ⭐ in the lower right corner. Show it when staring.

Sounds useful. I'll get to it when I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants