Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve main menu navigation experience #368

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

Master92
Copy link
Contributor

@Master92 Master92 commented Nov 7, 2023

When navigating the settings, the user has no feedback on if he/she is currently navigating the main menu or a sub menu except for the highlighting of elements in the submenu.

This PR changes the behavior of the navigation bar when entering and exiting a submenu element.
I.e. when navigating the main menu, no red arrow is shown. It only appears when entering a submenu. At this moment, the highlighting of the navigation bar changes, indicating a change in the level of navigation.

This feature is open to discussion, any opinion about it is highly appreciated! When accepted, it closes #363

Screenshots

Before

Before_main
Before_power

After

After_main
After_power

@SumolX
Copy link
Contributor

SumolX commented Nov 20, 2023

Would it be possible to modify the side menu selected entry to make it either bold or increase the font size slightly?

@Master92
Copy link
Contributor Author

Would it be possible to modify the side menu selected entry to make it either bold or increase the font size slightly?

Yes and no.
Although I'd prefer making the selected tab bold, it is unfortunately impossible without declaring a completely new font bitmap. Slightly increasing the font size is possible, yet unfortunately looks really weird imho.

FontSize

@ligenxxxx
Copy link
Member

In the past I thought the red arrow was redundant. Now it seems to have value. It seems to mean "Look to the right (submenu)".

@ligenxxxx
Copy link
Member

There are two ways to exit the secondary menu:

  • Press < Back or up and left-click. After my test, there is no problem.
  • Enter video mode. For example, automatically enter a certain channel after scanning. Or enter av in through source. At this time, the navigation triangle is not hidden. Please resolve this issue.

Although reverting 97f6853, this change fixes the behavior for all use cases
in which the indicator and highlighting stayed on after returning to the main menu.
@ligenxxxx ligenxxxx merged commit 608762e into hd-zero:main Nov 30, 2023
1 check passed
@Master92 Master92 deleted the menuNavigation branch November 30, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu highlight should change when in sub-menu
3 participants