Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin service descriptor paths to minion classpath #682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vampire
Copy link
Contributor

@Vampire Vampire commented Oct 1, 2019

In my use-case I have a spock test plugin in a separate Gradle source set.
I add the build output to the launch classpath.
The Gradle plugin sets hard includeLaunchClasspath to false.
The build output is added as .../build/classes/java/pitest and .../build/resources/pitest,
where the first contains the classes, the second the service descriptor.

The current logic searches the relevant services and then adds their code source
to the minion classpath.
This works fine if the class and descriptor are in one JAR how it usually is the case.
But for the described case, only the first path is added to the minion classpath
and then the Minion cannot find the configured test plugin.

There are two possible workarounds:

  1. pack the class and descriptor in one JAR or directory and add that to the launch classpath
  2. add the directories additionally to the classPath or classPathFile argument, so that they are always added to the minion classpath

@Vampire Vampire force-pushed the add-plugin-service-descriptor-paths-to-minion-classpath branch from 33c4d20 to beb6165 Compare October 5, 2019 12:34
@Vampire Vampire force-pushed the add-plugin-service-descriptor-paths-to-minion-classpath branch from beb6165 to abb216d Compare May 8, 2023 03:05
@Vampire
Copy link
Contributor Author

Vampire commented May 8, 2023

I updated this PR to latest master, maybe you have time for it now. :-)

@Vampire Vampire force-pushed the add-plugin-service-descriptor-paths-to-minion-classpath branch 8 times, most recently from 4244461 to 35131e9 Compare May 16, 2023 09:49
@Vampire Vampire force-pushed the add-plugin-service-descriptor-paths-to-minion-classpath branch 4 times, most recently from 880b15a to 6160178 Compare May 25, 2023 08:08
@Vampire Vampire force-pushed the add-plugin-service-descriptor-paths-to-minion-classpath branch from 6160178 to 5710610 Compare May 30, 2023 09:20
@Vampire Vampire force-pushed the add-plugin-service-descriptor-paths-to-minion-classpath branch from 5710610 to d28c6d6 Compare June 10, 2023 19:33
@Vampire Vampire force-pushed the add-plugin-service-descriptor-paths-to-minion-classpath branch from d28c6d6 to 15f13e4 Compare June 22, 2023 19:49
@Vampire Vampire force-pushed the add-plugin-service-descriptor-paths-to-minion-classpath branch from 15f13e4 to 30b522b Compare June 23, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant