Add initial transactor rpc #7490
Open
+167
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiodo
reviewed
Dec 17, 2024
workers/transactor/src/index.ts
Outdated
|
|
||
| export class TransactorRPC extends WorkerEntrypoint<Env> { | ||
| async rpcFindAll ( | ||
| token: string, |
There was a problem hiding this comment.
Please add workspaceId here, so could think about security at next step
There was a problem hiding this comment.
I don't like that we have to pass token and workspaceId fro every request. I propose to use stubs to hide this.
In the transactor there will be only one method, named connect (or any other name) that will return stub with two methods: find and tx.
https://developers.cloudflare.com/workers/runtime-apis/rpc/
using client = env.TRANSACTOR.connect(token, workspaceId)
await client.tx(...)
Signed-off-by: Andrey Sobolev <[email protected]>
Signed-off-by: Nikolay Chunosov <[email protected]>
Signed-off-by: Nikolay Chunosov <[email protected]>
Signed-off-by: Nikolay Chunosov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huly®: UBERF-8958