Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates #7295

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

UI updates #7295

wants to merge 5 commits into from

Conversation

logicsec
Copy link

@logicsec logicsec commented Dec 8, 2024

Standardize Panel Design System

Overview

Implemented a new floating panel design system across the application to improve visual consistency and hierarchy.

Visual Impact

  • Creates visual separation between panels through consistent floating design
  • Improves overall application hierarchy through standardized spacing
  • Enhances readability with unified panel coloring

Technical Notes

  • Leverages existing theme variables for maintainable styling
  • Ensures consistent implementation across different viewport sizes
  • Maintains responsive behavior while improving visual consistency

Testing

  • Verified panel styling across different screen sizes
  • Confirmed theme compatibility (light/dark modes)
  • Validated margin spacing and panel interactions

Screenshots

image image image image image image

@logicsec
Copy link
Author

@SasLord @aonnikov wanted to check in on this to see if there was anything pending?

@MilanovaSmile
Copy link
Contributor

I really like this design. @aonnikov Is there a chance that it will be merged?

@aonnikov
Copy link
Member

Hey @logicsec , thanks for the contribution! I like this design, but not sure if we are going to apply this. We discussed it internally but have not decided yet. It appears that separation takes more place now that might be a problem on small screen. We already have this problem with many panels opened at the same time, don't want to make it worse.

@logicsec
Copy link
Author

Should be an easy update on my end to make this responsive. The issue is that when you get on smaller screens, you need to modify the viewport. I noticed this on a lot of the design is using statically assigned margins or margins with pt instead of using dynamic margins like rem or using the built-ins like margin-2.

I can run through mobile screen sizes just to see how they look at post back here on how it looks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants