CF Transactor(initial) #7037
Open
CF Transactor(initial) #7037
+1,605
−450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiodo
force-pushed
the
UBERF-7922p3
branch
3 times, most recently
from
d73373a to
1e90dd8
Compare
Chunosov
force-pushed
the
UBERF-7922p3
branch
2 times, most recently
from
b787f51 to
17205fb
Compare
aonnikov
reviewed
Dec 17, 2024
| # - https://developers.cloudflare.com/workers/wrangler/configuration/#environment-variables | ||
| # Note: Use secrets to store sensitive data. | ||
| # - https://developers.cloudflare.com/workers/configuration/secrets/ | ||
| [vars] |
There was a problem hiding this comment.
please add dev/staging configs, or just staging with dev as default
workers/transactor/src/transactor.ts
Outdated
|
|
||
| setMetadata(serverPlugin.metadata.Secret, env.SERVER_SECRET) | ||
|
|
||
| console.log('Connecting DB to', env.HYPERDRIVE.connectionString) |
There was a problem hiding this comment.
nit: cloudflare recommends use objects for logging:
console.log({ message: 'Connecting DB to', hyperdrive: env.HYPERDRIVE.connectionString })
Signed-off-by: Andrey Sobolev <[email protected]>
Signed-off-by: Nikolay Chunosov <[email protected]>
Signed-off-by: Nikolay Chunosov <[email protected]>
Signed-off-by: Nikolay Chunosov <[email protected]>
Signed-off-by: Nikolay Chunosov <[email protected]>
Signed-off-by: Victor Ilyushchenko <[email protected]>
Signed-off-by: Andrey Sobolev <[email protected]>
Signed-off-by: Andrey Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CF Transactor(initial)