Fix bad link formatting #5985
Open
Fix bad link formatting #5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kujaomega
force-pushed
the
main
branch
2 times, most recently
from
3ab2144
to
8861698
Compare
Signed-off-by: DavidS <[email protected]>
aonnikov
requested changes
Jul 3, 2024
| @@ -54,11 +54,7 @@ export const DefaultKit = Extension.create<DefaultKitOptions>({ | |||
| Highlight.configure({ | |||
| multicolor: false | |||
| }), | |||
| Typography.configure({}), | |||
| Link.configure({ | |||
There was a problem hiding this comment.
You cannot just remove this extension:
- Link button in toolbar will be broken
- Existing content that contains links will be broken
| @@ -49,7 +100,9 @@ | |||
| {#if node.type === MarkupNodeType.doc} | |||
| <MarkupNodes {nodes} {preview} /> | |||
| {:else if node.type === MarkupNodeType.text} | |||
| {node.text} | |||
| <p> | |||
There was a problem hiding this comment.
adding additional paragraphs may affect layout
| @@ -49,7 +100,9 @@ | |||
| {#if node.type === MarkupNodeType.doc} | |||
| <MarkupNodes {nodes} {preview} /> | |||
| {:else if node.type === MarkupNodeType.text} | |||
| {node.text} | |||
| <p> | |||
| {@html urlify(node.text)} | |||
There was a problem hiding this comment.
@html is potentially dangerous , we are trying not to use it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Requirements:
This PR removes link formatting from tiptap fixing bad link formatting:
The changes adds links to URLs only.