- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace next-secure-headers with Nosecone for security headers #343
Merged
+150
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@davidmytton is attempting to deploy a commit to the Hayden Bleasel Team on Vercel. A member of the Team first needs to authorize it. |
davidmytton
commented
Dec 10, 2024
Great work as usual @davidmytton, thanks! |
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Changes only affect the documentation
released
This issue/pull request has been released.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
next-secure-headers hasn't been updated for 3 years and is setting obsolete security headers. We just released Nosecone which is an open source library for configuring security headers like CSP and HSTS on Next.js and other frameworks.
As discussed in the PR, CSP is not set by default. We can revisit when #332 is done. There is a working example config in the docs.
next-secure-headers vs Nosecone
Loading http://localhost:3000/sign-in sets the following headers:
With Nosecone, the same page sets the following:
The headers removed are:
Expect-CT
= deprecatedX-XSS-Protection
= deprecated, but set to0
because other values are a security vulnerabilityChecklist