Change default shell from /bin/ash to /bin/sh

[rskallies]

Proposed Changes

Change default shell from /bin/ash to /bin/sh

Related Issues

#744

Summary by CodeRabbit

• Chores
  • Updated the SSH Dockerfile to use zsh instead of sh for the default shell environment. This change affects the shell experience by providing enhanced features and a more user-friendly interface.

[coderabbitai]

Walkthrough

The update in the ssh/Dockerfile involves a streamlined modification: altering the sed command to replace /bin/sh with /bin/zsh in the /etc/passwd file. This change aims to ensure that the system uses zsh instead of the default sh shell for users.

Changes

Files	Change Summary
ssh/Dockerfile	Updated the sed command to change bin/sh to bin/zsh in /etc/passwd

Poem

In a Docker's gentle might,
/bin/sh takes its flight,
Replaced by zsh, bright and clear,
A shell that brings so much cheer.
A twist of code, a simple mend,
Now zsh greets us, like a friend. 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 629ed20 and 4451e44.

Files selected for processing (1)

• ssh/Dockerfile (1 hunks)

Files skipped from review due to trivial changes (1)

• ssh/Dockerfile

[dfries]

I'm seeing /etc/passwd
root:x:0:0:root:/root:/bin/sh
so I can see why sed -i -e "s#bin/ash#bin/zsh#" /etc/passwd would fail.
Please make the shell configurable. I see bash is installed and that's my preference.
zsh prompt on the other hand takes much longer to startup and the prompt outputs unprintable garbage at the start.

[frenck]

Please make the shell configurable. I see bash is installed and that's my preference.

That is already configurable, please read some documentation, that is my preference 😛

[frenck]

This PR fails, caused by the base image to be behind. I'm trying to debug why Renovate didn't make an update / PR to bump the dependency (that has been available for two weeks at this point).

../Frenck

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4451e44 and 082c867.

Files selected for processing (1)

• ssh/Dockerfile (1 hunks)

Files skipped from review due to trivial changes (1)

• ssh/Dockerfile

[frenck]

You are kinda out of scope for this Pr. Let's keep PR to reviews please. Thanks 🙏

[frenck]

Thanks @rskallies 👍

Will ship in the morning (got an Alpine Linux update ln route as well).

../Frenck

[dfries]

Back to this pull request then.

I'm thinking it was /bin/ash it is /bin/sh what if it were changed to /bin/dash in the future? Could check for bin/.*sh

&& sed -i -e "s#bin/.*sh#bin/zsh#" /etc/passwd \

Could completely ignore the shell, but this assumes only root will ever need updating.

sed -i -e 's#^\(root.*:\)/bin.*#\1/bin/zsh#' /etc/passwd \