-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default shell from /bin/ash to /bin/sh #747
Conversation
WalkthroughThe update in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
I'm seeing /etc/passwd |
That is already configurable, please read some documentation, that is my preference 😛 |
This PR fails, caused by the base image to be behind. I'm trying to debug why Renovate didn't make an update / PR to bump the dependency (that has been available for two weeks at this point). ../Frenck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
This comment has been minimized.
This comment has been minimized.
You are kinda out of scope for this Pr. Let's keep PR to reviews please. Thanks 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rskallies 👍
Will ship in the morning (got an Alpine Linux update ln route as well).
../Frenck
Back to this pull request then. I'm thinking it was /bin/ash it is /bin/sh what if it were changed to /bin/dash in the future? Could check for bin/.*sh
Could completely ignore the shell, but this assumes only root will ever need updating.
|
Proposed Changes
Change default shell from /bin/ash to /bin/sh
Related Issues
#744
Summary by CodeRabbit
zsh
instead ofsh
for the default shell environment. This change affects the shell experience by providing enhanced features and a more user-friendly interface.