Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split config_entries data into data and options parts #66

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

NecroKote
Copy link

@NecroKote NecroKote commented Jan 25, 2024

This allows changing all parameters other than integration type and
it's id at any point

This change also contains a bump to SCHEMA_VERSION up to 4 and a migration steps for existing configurations of version 3

I've only checked this with "SL Departure" integration, so additional testing is much appreciated :)

Fixes #51

DSorlov and others added 2 commits June 12, 2023 12:00
This allows changing all parameters other than integration type and
it's id at any point.

This change also contains bump to SCHEMA_VERSION up to 4, and a
migration steps for existing configurations of version 3
@pep8speaks
Copy link

Hello @NecroKote! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 273:80: E501 line too long (88 > 79 characters)

Line 44:12: E713 test for membership should be 'not in'
Line 46:80: E501 line too long (90 > 79 characters)
Line 48:80: E501 line too long (80 > 79 characters)
Line 100:80: E501 line too long (84 > 79 characters)
Line 102:80: E501 line too long (227 > 79 characters)
Line 111:80: E501 line too long (84 > 79 characters)

Line 151:80: E501 line too long (81 > 79 characters)
Line 152:80: E501 line too long (85 > 79 characters)
Line 154:80: E501 line too long (88 > 79 characters)
Line 156:80: E501 line too long (96 > 79 characters)
Line 202:80: E501 line too long (84 > 79 characters)

Line 81:80: E501 line too long (81 > 79 characters)
Line 82:80: E501 line too long (99 > 79 characters)
Line 83:80: E501 line too long (95 > 79 characters)
Line 94:80: E501 line too long (109 > 79 characters)
Line 95:80: E501 line too long (91 > 79 characters)
Line 97:80: E501 line too long (109 > 79 characters)
Line 98:80: E501 line too long (91 > 79 characters)
Line 110:80: E501 line too long (132 > 79 characters)
Line 111:80: E501 line too long (130 > 79 characters)
Line 126:80: E501 line too long (87 > 79 characters)
Line 174:80: E501 line too long (80 > 79 characters)
Line 175:80: E501 line too long (98 > 79 characters)
Line 176:80: E501 line too long (97 > 79 characters)
Line 186:80: E501 line too long (80 > 79 characters)
Line 187:80: E501 line too long (98 > 79 characters)
Line 188:80: E501 line too long (95 > 79 characters)
Line 199:80: E501 line too long (133 > 79 characters)
Line 200:80: E501 line too long (134 > 79 characters)
Line 248:80: E501 line too long (203 > 79 characters)
Line 373:80: E501 line too long (203 > 79 characters)
Line 502:80: E501 line too long (97 > 79 characters)
Line 519:80: E501 line too long (205 > 79 characters)
Line 717:80: E501 line too long (97 > 79 characters)
Line 734:80: E501 line too long (205 > 79 characters)
Line 917:80: E501 line too long (97 > 79 characters)
Line 934:80: E501 line too long (205 > 79 characters)
Line 1120:80: E501 line too long (238 > 79 characters)
Line 1224:80: E501 line too long (209 > 79 characters)
Line 1325:80: E501 line too long (84 > 79 characters)
Line 1327:80: E501 line too long (227 > 79 characters)
Line 1336:80: E501 line too long (84 > 79 characters)

@DSorlov DSorlov merged commit bb6d542 into hasl-sensor:dev Feb 7, 2024
@NecroKote NecroKote deleted the split-configuration branch February 7, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants