More unicode syntax replacements #436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've refactored UnicodeSyntax step and extended number of replacable symbols. Old replacement rules for
->,::and=>in function type declaration were replaced by more abstract, working for GADTs too. Many other symbols added.There are some problems with Arrow notation: in official documentation I've found only two operators:
-<and-<<. According two the GHC parser lib there is also>>-. I've added appropriate replacement rule without tests.I've added several base test cases, maybe missed some significant point. I'd be glad for any remarks and corrections.
Issues #3, #81, #93, #408, #418, and #430 are expected to be closed by this PR. If I missed some symbols, let me know, please. I think it's reasonable to add all the unicode syntax support at once