Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ghc 9.12 #72

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Support ghc 9.12 #72

merged 1 commit into from
Nov 8, 2024

Conversation

erikd
Copy link
Member

@erikd erikd commented Nov 5, 2024

No description provided.

@andreasabel
Copy link
Member

@erikd Could you also add 9.12.0 to tested-with and update the Haskell CI.
After installing my fork https://github.com/andreasabel/haskell-ci run haskell-ci regenerate.
You might have to bump the other tested-with entries to the latest GHC minor versions Also GHC 7 isn't supported any more by Haskell Ci.

@erikd erikd force-pushed the master branch 2 times, most recently from 2fa7c86 to 8f08406 Compare November 7, 2024 01:30
@erikd
Copy link
Member Author

erikd commented Nov 7, 2024

@andreasabel Done

andreasabel
andreasabel requested changes Nov 7, 2024
View reviewed changes
Copy link
Member

@andreasabel andreasabel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I think it would be good if CI tested the new base bound, so GHC 9.12 should be included in CI.
Latest builds [My fork] of Haskell CI do support[s] the alpha1 version.

.github/workflows/haskell-ci.yml Outdated
#
# REGENDATA ("0.19.20240403",["github","parallel.cabal"])
# REGENDATA ("0.19.20240708",["github","parallel.cabal"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of haskell-ci is too old, does not know about GHC 9.12 yet.

parallel.cabal Outdated
@@ -12,9 +12,11 @@ category: Control, Parallelism
build-type: Simple

tested-with:
GHC == 9.10.0
-- Not supported yet
-- GHC == 9.12.0
Copy link
Member

@andreasabel andreasabel Nov 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fork supports 9.12.0, I think on the original Haskell CI the same is called 9.12.1.
(No, only my fork works: haskell-CI/haskell-ci#746)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am currently using the one from https://github.com/haskell-CI/haskell-ci @ master 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now used your branch.

andreasabel
andreasabel approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@andreasabel andreasabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@andreasabel andreasabel merged commit f837016 into haskell:master Nov 8, 2024
13 checks passed
@andreasabel
Copy link
Member

Published as revision 9: https://hackage.haskell.org/package/parallel-3.2.2.0/revisions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasabel andreasabel andreasabel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikd @andreasabel