Remove usage of QuasiQuotes #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to allow directory to be build with GHC Fixes #192
|
@hasufell, It's important to avoid using template haskell in boot packages as there are platforms which don't support using it. (See the same issue in haskell/os-string#21) |
hasufell
reviewed
Oct 3, 2024
| (mkUTF16le ErrorOnCodingFailure) | ||
| ".copyFile.tmp" | ||
| of | ||
| Left err -> error ("withReplacementFile: invalid encoding: " ++ show err) |
There was a problem hiding this comment.
error is a bit depressing, why don't we throw an IO error?
There was a problem hiding this comment.
It's not something that should really happen under any usage of the library, so I don't see the benefit of throwIO which makes it easier to catch.
There was a problem hiding this comment.
Yeah, doesn't matter much sense it's a static string.
|
@hasufell any updates here? |
|
I'm not a maintainer, just commenting, because I was involved in the code. |
|
ping @Rufflewind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of QuasiQuotes
This is necessary to allow directory to be build with GHC
Fixes #192