Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'findExecutable' "" should return Nothing, like on linux #186

Merged
merged 1 commit into from
Aug 28, 2024
Merged

'findExecutable' "" should return Nothing, like on linux #186

merged 1 commit into from
Aug 28, 2024

Conversation

hasufell
Copy link
Member

Fixes #180

hasufell
hasufell commented Aug 17, 2024
View reviewed changes
System/Directory/Internal/Windows.hsc
(OsString <$>) <$>
Win32.searchPath Nothing binary (Just (getOsString exeExtension))
searchPathEnvForExes (OsString binary) = search `catch` \e ->
if ioeGetErrorType e == InvalidArgument
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the only user-supplied argument is the filename, this is granular enough.

@Rufflewind
Copy link
Member

Thanks!

@Rufflewind Rufflewind merged commit 7582869 into haskell:master Aug 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rufflewind Rufflewind Awaiting requested review from Rufflewind

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FR: findExecutable "" should return Nothing, like on linux
2 participants
@hasufell @Rufflewind