Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "install-includes: HsDirectoryConfig.h" #184

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

mpickering
Copy link
Contributor

This header file is not supposed to be installed for users, users are not supposed to use it. The file exists to be used interally (and this is explained by the "include-dirs" field in the cabal file.

It seems likely that this removal was overlooked in c87be99

This header file is not supposed to be installed for users, users are
not supposed to use it. The file exists to be used interally (and this
is explained by the "include-dirs" field in the cabal file.

It seems likely that this removal was overlooked in
c87be99
@mpickering
Copy link
Contributor Author

This is likely to have been broken for at least 6 years anyway due to this Cabal bug - haskell/cabal#10238

@juhp
Copy link

juhp commented Aug 3, 2024

Ah, is this the cause of:

$ ghc-pkg check
Warning: include-dirs: /usr/lib64/ghc-9.6.6/lib/../lib/x86_64-linux-ghc-9.6.6/directory-1.3.8.5/include doesn't exist or isn't a directory

or is that unrelated? (also for 9.8)

I was wondering if include-dirs: . should also be removed from directory.cabal?

@Rufflewind Rufflewind merged commit 6045b93 into haskell:master Aug 3, 2024
11 checks passed
@mpickering
Copy link
Contributor Author

Yes it is the cause of that warning @juhp, and no the include-dirs still needs to be there as the header needs to be found when building directory itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants