Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bounds of filepath dependency #169

Closed
wants to merge 1 commit into from

Conversation

BinderDavid
Copy link
Contributor

Change bounds from <1.4.200 || >= 1.5 to <1.4.300 || >= 1.5

Change bounds from <1.4.200 || >= 1.5 to <1.4.300 || >= 1.5
@BinderDavid
Copy link
Contributor Author

I tried to bump directory in GHC, but GHC uses filepath=1.4.200.1 which is currently excluded in the bounds of directory.

MR in Gitlab is here: https://gitlab.haskell.org/ghc/ghc/-/merge_requests/11957

@Bodigrim
Copy link
Contributor

Why not bump filepath submodule to 1.5 instead? This is long overdue.

@BinderDavid
Copy link
Contributor Author

BinderDavid commented Jan 22, 2024

Why not bump filepath submodule to 1.5 instead? This is long overdue.

I was hoping that I could get away with just a smaller minor version bump. (Originally it all started because I want to get https://gitlab.haskell.org/ghc/ghc/-/merge_requests/11679 merged). But it seems to me that bumping filepath to a new major version is the most sensible way forward. But it will involve bumping several dependencies in GHC at the same time (at least filepath, directory and Win32). This probably needs some bigger coordination...

@Rufflewind
Copy link
Member

Change bounds from <1.4.200 || >= 1.5 to <1.4.300 || >= 1.5

FWIW, this was causing deprecation alerts:

Module ‘System.OsString.Internal.Types’ is deprecated:

and that's why 1.4.200 wasn't marked as supported.

@BinderDavid
Copy link
Contributor Author

Yes, I noticed this now. I think this PR won't be necessary if GHC goes forward with migrating to filepath 1.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants