Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on a fix for #10527 and noticed that all but one of the callers of
withContextAndSelectors
had already accessed verbosity in the same way thatwithContextAndSelectors
does (Cmd*.hs
modules do this):cabal/cabal-install/src/Distribution/Client/CmdRepl.hs
Line 509 in 62073c9
cabal/cabal-install/src/Distribution/Client/ScriptUtils.hs
Line 340 in 62073c9
This is a refactor that adds a verbosity argument to
withContextAndSelectors
and a functioncfgVerbosity
that simplifies grabbing the verbosity from the configuration or using a default value.With this a lot of
-XRecordWildCards
can be removed as can a lot of imports fromDistribution.Client.Setup
.This will help with my fix for #10527 too as I may have to call
withContextAndSelectors
twice1 and don't want repeated messaging so would silence the verbosity of the first call.Footnotes
Depending on whether
cabal repl
should pick the one target, Shouldcabal repl
pick the one package library as TARGET? #10689. ↩