Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: prerelease: fixup cleanup (again) #10662

Merged
merged 1 commit into from
Dec 23, 2024
Merged

CI: prerelease: fixup cleanup (again) #10662

merged 1 commit into from
Dec 23, 2024

Conversation

ulysses4ever
Copy link
Collaborator

Currently failing due to liudonghua123/delete-release-action#1

Petition to fast-track (again)...

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@ulysses4ever ulysses4ever mentioned this pull request Dec 21, 2024
Merged
2 tasks
geekosaur
geekosaur approved these changes Dec 21, 2024
View reviewed changes
Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's odd though, github.token is supposed to be the current job's token and I've used it as such in other contexts.

I'll also have to do this (manually since prereleases are in separate jobs) in #10503

@ulysses4ever ulysses4ever requested a review from ffaf1 December 23, 2024 18:31
@ulysses4ever ulysses4ever added merge me Tell Mergify Bot to merge and removed attention: needs-review labels Dec 23, 2024
@mergify mergify bot added merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days ready and waiting Mergify is waiting out the cooldown period labels Dec 23, 2024
@Mikolaj Mikolaj force-pushed the ulysses4ever-prerelease-cleanup-fixup branch from 09bd2f0 to 466e4cc Compare December 23, 2024 21:09
@mergify mergify bot merged commit 5ad146c into master Dec 23, 2024
50 checks passed
@mergify mergify bot deleted the ulysses4ever-prerelease-cleanup-fixup branch December 23, 2024 22:33
@geekosaur geekosaur mentioned this pull request Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ffaf1 ffaf1 ffaf1 approved these changes

@geekosaur geekosaur geekosaur approved these changes

@Mikolaj Mikolaj Awaiting requested review from Mikolaj

Assignees
No one assigned
Labels
continuous-integration merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge priority: high 🔥 ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ulysses4ever @geekosaur @ffaf1